Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log Git tool commands when running in verbose mode #15514

Merged
merged 5 commits into from
Jan 26, 2024
Merged

Log Git tool commands when running in verbose mode #15514

merged 5 commits into from
Jan 26, 2024

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Jan 24, 2024 •
edited by czoido
Loading

Changelog: Feature: Log Git tool commands when running in verbose mode.
Docs: Omit

Closes #7029

@AbrilRBS AbrilRBS added this to the 2.1 milestone Jan 24, 2024
memsharded
memsharded reviewed Jan 24, 2024
View reviewed changes
conan/tools/scm/git.py Outdated Show resolved Hide resolved
memsharded
memsharded approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of hiding the full URL, no risks this way.

memsharded
memsharded reviewed Jan 26, 2024
View reviewed changes
conan/tools/scm/git.py Outdated Show resolved Hide resolved
@memsharded memsharded merged commit 20517df into conan-io:develop2 Jan 26, 2024
2 checks passed
@AbrilRBS AbrilRBS deleted the rr/git-verbose-run-command-log branch January 26, 2024 14:33
@shoeffner shoeffner mentioned this pull request Feb 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

@franramirez688 franramirez688 Awaiting requested review from franramirez688

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

[feature] Print git commands when print_run_commands = True
3 participants
@AbrilRBS @franramirez688 @memsharded