[MesonToolchain] Using get_apple_sdk_fullname to avoid empty apple minimum version flag
#15465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
reviewed
Jan 21, 2024
conans/test/integration/toolchains/meson/test_mesontoolchain.py
Outdated
Show resolved
Hide resolved
franramirez688
commented
Jan 22, 2024
conans/test/functional/toolchains/meson/test_cross_compilation.py
Outdated
Show resolved
Hide resolved
memsharded
approved these changes
Jan 22, 2024
conans/test/functional/toolchains/meson/test_cross_compilation.py
Outdated
Show resolved
Hide resolved
franramirez688
force-pushed
the
frm/macos_sdk_min_flag
branch
from
c428df6 to
a9526fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: MesonToolchain calculates a valid
apple_min_version_flag.Docs: omit
Closes: #15459