-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding cmakeExecutable to presets #15447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Co-authored-by: James <james@conan.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good! just one comment, but it shouldn't be a problem.
I wonder if it would be useful to have a an attribute in CMakeToolchain that the users could set in the generate()
method, if they so wish? , in case they're in a universe where cmake is not in the system path, and also not a tool_requirement (think a CI machine that has multiple CMake versions installed in different places)
We already have self._cmake_program = conanfile.conf.get("tools.cmake:cmake_program", default="cmake") Inside the |
I made changes to read that conf with preference |
Changelog: Feature: Add cmakeExecutable to configure preset.
Docs: conan-io/docs#3548
Closes: #15427