Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getting environment variable CONAN_LOGIN_USERNAME_<REMOTE> #15388

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Jan 4, 2024

Trying to fix the ci for artifactory custom command in conan-extensions I found out that the authentication for certain commands is not managed correctly when using environment variables with the remote names in the end like CONAN_LOGIN_USERNAME_EXTENSIONS_PROD. This changes the environment variable management in conan auth but the problem is not solved with this. I still need to investigate it more in deep, leaving this PR here so we don't forget.

I had to change to conan remote login: conan-io/conan-extensions#95 (comment)

Changelog: Bugfix: Fix getting environment variable CONAN_LOGIN_USERNAME_REMOTE.
Docs: Omit

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@czoido czoido added this to the 2.1 milestone Jan 4, 2024
@czoido czoido marked this pull request as ready for review January 24, 2024 11:21
@czoido czoido changed the title Investigate some authentication problems when using CONAN_LOGIN environment variables Fix getting environment variable CONAN_LOGIN_USERNAME_<REMOTE> Jan 24, 2024
@memsharded memsharded merged commit 21516d4 into conan-io:develop2 Jan 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants