Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intel oneapi detection #15358

Merged
merged 9 commits into from
Dec 28, 2023
Merged

Intel oneapi detection #15358

merged 9 commits into from
Dec 28, 2023

Conversation

jakeheke75
Copy link
Contributor

@jakeheke75 jakeheke75 commented Dec 28, 2023 •
edited by AbrilRBS
Loading

Changelog: Feature: Intel oneAPI compiler detection improvement.
Docs: Omit
Fixes #15344

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop2 branch, documenting this one.

@CLAassistant
Copy link

CLAassistant commented Dec 28, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

memsharded
memsharded approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, just a couple of questions, but I think it can otherwise be merged for next 2.1

conan/internal/api/detect_api.py Outdated Show resolved Hide resolved
conans/client/conf/__init__.py Show resolved Hide resolved
@memsharded memsharded added this to the 2.1 milestone Dec 28, 2023
memsharded
memsharded approved these changes Dec 28, 2023
View reviewed changes
conan/internal/api/detect_api.py Show resolved Hide resolved
conan/internal/api/detect_api.py Outdated Show resolved Hide resolved
@memsharded
Copy link
Member

Looks good, I think you can take it out of draft :)

@jakeheke75 jakeheke75 marked this pull request as ready for review December 28, 2023 20:03
@jakeheke75 jakeheke75 mentioned this pull request Dec 28, 2023
Draft
@memsharded memsharded merged commit 0a93689 into conan-io:develop2 Dec 28, 2023
2 checks passed
@memsharded
Copy link
Member

Merged, good job, thanks very much!
This will be in next Conan 2.1

@memsharded memsharded mentioned this pull request Dec 28, 2023
Closed
1 task
@jakeheke75
Copy link
Contributor Author

Merged, good job, thanks very much! This will be in next Conan 2.1

It would not have been possible without your help. Thank you for all the support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

[feature] Improve detect API to support Intel oneAPI compiler
3 participants
@jakeheke75 @CLAassistant @memsharded