Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't take . folder into consideration for tools.files.copy() excludes patterns #15349

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Don't take . folder into consideration for tools.files.copy() excludes patterns #15349

merged 2 commits into from
Dec 27, 2023

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Dec 26, 2023 •
edited by czoido
Loading

Changelog: Bugfix: Don't take . folder into consideration for tools.files.copy() excludes patterns.
Docs: Omit

Closes #9208

As per https://docs.python.org/3/library/os.path.html#os.path.relpath and my own testing, relpath folders do not start with a ./ from the source

@AbrilRBS AbrilRBS added this to the 2.1 milestone Dec 26, 2023
@AbrilRBS AbrilRBS requested a review from memsharded December 26, 2023 19:07
memsharded
memsharded approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, have a look at the possible test improvement (you can discard it too, no prob), and you can merge it.

conans/test/unittests/tools/files/test_tool_copy.py Outdated Show resolved Hide resolved
@memsharded memsharded merged commit bde2eaa into conan-io:develop2 Dec 27, 2023
2 checks passed
@memsharded memsharded mentioned this pull request Dec 27, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

[question] Strange behavior of self.copy excludes patterns
2 participants
@AbrilRBS @memsharded