Disable creating editables without name and version #15337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
changed the title
conan test works for editables without version
memsharded
reviewed
Dec 22, 2023
AbrilRBS
changed the title
conan test works for editables without version
memsharded
approved these changes
Dec 26, 2023
memsharded
pushed a commit
to memsharded/conan
that referenced
this pull request
Dec 28, 2023
* Add test to ensure conan test works for editables without version * Disable creation of editables without name & version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Disable creating editables without name and version.
Docs: Omit
After looking into it with the team, we have decided that creating editables without specifying a name and version is an anti-pattern