Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make core:warnings_as_errors accept a list #15297

Merged
merged 5 commits into from
Dec 19, 2023

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Dec 19, 2023

Changelog: Fix: Make core:warnings_as_errors accept a list
Docs: Omit

WIP, uploading to get it out as soon as it's done :)

@AbrilRBS AbrilRBS added this to the 2.0.15 milestone Dec 19, 2023
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please check:

def error(self, msg, error_type=None):
        if self._conan_output_level <= LEVEL_ERROR:
            if self._warnings_as_errors and error_type != "exception":
                raise ConanException(msg)

I wouldn't condition the exception to the log-level LEVEL_ERROR. Even if it is not logged, we want it to raise and report it.

@AbrilRBS AbrilRBS marked this pull request as ready for review December 19, 2023 11:37
@czoido czoido merged commit ff612f2 into conan-io:release/2.0 Dec 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants