-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Git.get_url_and_commit
raising for some Git configs
#15271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be necessary to add a test that covers the need for this, so if someone sometime removes it, the test will fail.
There are a bunch of tests in test_git.py
that you could use as a base, but let us know if you need help, we can even try to contribute the test if necessary.
I'll get familiar with your setup and I will create the tests, no prob! |
Hi @Solviana I am submitting a very related PR to fix a If you'd like to include this fix in 2.0.15, it will be most likely branched tomorrow, if you could manage to do the test, please let me know, and I'll try to include it. |
bc79ebf
to
eee2daa
Compare
I was afk for a while but now I updated the PR with some tests. Can you review this again? |
eee2daa
to
09d9774
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look great, thanks very much!
The new flags are 10 and 15 years old, respectively - no need for us to worry about that I think heh. I've now modified the PR message, and will merge this to be released for 2.1, thanks a lot for your contribution @Solviana, we really appreciate it :) |
Git.get_url_and_commit
raising for some Git configs
…5271) Fix dirty repo handling (conan-io#15261)
Changelog: Bugfix: Fix
Git.get_url_and_commit
raising for some Git configs.Docs: Omit
develop
branch, documenting this one.