Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed conan migration compatibility warning #15174

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Removed conan migration compatibility warning #15174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions conan/cli/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,16 +191,6 @@ def _conan2_migrate_recipe_msg(exception):
"If it is your recipe, check if it is updated to 2.0\n" \
"*********************************************************\n"
ConanOutput().writeln(error, fg=Color.BRIGHT_MAGENTA)
result = re.search(r"(.*): Error in build\(\) method, line", message)
if result:
pkg = result.group(1)
error = "*********************************************************\n" \
f"Recipe '{pkg}' cannot build its binary\n" \
f"It is possible that this recipe is not Conan 2.0 ready\n" \
"If the recipe comes from ConanCenter, report it at https://github.com/conan-io/conan-center-index/issues\n" \
"If it is your recipe, check if it is updated to 2.0\n" \
"*********************************************************\n"
ConanOutput().writeln(error, fg=Color.BRIGHT_MAGENTA)

@staticmethod
def exception_exit_error(exception):
Expand Down
17 changes: 0 additions & 17 deletions conans/test/integration/conan_v2/test_legacy_cpp_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,20 +65,3 @@ class Pkg(ConanFile):
assert "Recipe 'pkg/1.0' seems broken." in c.out
assert "It is possible that this recipe is not Conan 2.0 ready" in c.out

def test_legacy_build(self):
c = TestClient()
conanfile = textwrap.dedent("""
from conan import ConanFile
class Pkg(ConanFile):
name = "pkg"
version = "1.0"

def build(self):
raise Exception("Build broken")
""")
c.save({"pkg/conanfile.py": conanfile,
"app/conanfile.py": GenConanfile("app", "1.0").with_requires("pkg/1.0")})
c.run("export pkg")
c.run("install app --build=missing", assert_error=True)
assert "Recipe 'pkg/1.0' cannot build its binary" in c.out
assert "It is possible that this recipe is not Conan 2.0 ready" in c.out