Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not skipping binaries of direct dependencies for packages being built #15128

Merged

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Nov 17, 2023

Changelog: Bugfix: Direct dependencies in the "host" context of packages being built shouldn't be skipped. This allows for non C/C++ libraries artifacts, like images, in the "host" context, to be used as build-time resources.
Docs: Omit

@memsharded memsharded changed the title to explorer teh concept of not skipping directs To explorer the concept of not skipping directs Nov 17, 2023
@memsharded memsharded changed the base branch from release/2.0 to develop2 January 24, 2024 10:20
@memsharded memsharded marked this pull request as ready for review January 24, 2024 10:21
@memsharded memsharded changed the title To explorer the concept of not skipping directs Not skipping binaries of direct dependencies for packages being built Jan 24, 2024
@memsharded memsharded added this to the 2.1 milestone Jan 24, 2024
@memsharded memsharded requested a review from AbrilRBS January 24, 2024 10:23
@memsharded memsharded merged commit 1268572 into conan-io:develop2 Feb 5, 2024
2 checks passed
@memsharded memsharded deleted the fix/no_skip_invisible_direct_requires branch February 5, 2024 16:23
memsharded added a commit to memsharded/conan that referenced this pull request Feb 8, 2024
…conan-io#15128)

* to explorer teh concept of not skipping directs

* fix

* wip

* review
czoido pushed a commit that referenced this pull request Feb 12, 2024
* fix relativize paths in generated files

* Fix msvc profile detect test (#15552)

remove test line

Co-authored-by: Rubén Rincón Blanco <rubenrb@jfrog.com>

* recover xfail test for win_bash=True with msvc (#15593)

* Not skipping binaries of direct dependencies for packages being built (#15128)

* to explorer teh concept of not skipping directs

* fix

* wip

* review

* wip

---------

Co-authored-by: Juan <35701596+juansblanco@users.noreply.github.com>
Co-authored-by: Rubén Rincón Blanco <rubenrb@jfrog.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants