Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stderr capture argument to conanfile's run() method #15121

Merged

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Nov 16, 2023

Changelog: Feature: Add stderr capture argument to conanfile's run() method.
Docs: conan-io/docs#3482

To discuss with the team if we want this feature, but it was so simple to implement that I decided to create the PR before discussing it (Not sold on the test, I would like a better method to test stderr that does not rely on descriptor copying)

Added as a last argument because I'm afraid some users are relying on the order of the parameters so it did not feel right to add it after stdout

Closes #15118

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@AbrilRBS AbrilRBS marked this pull request as ready for review November 16, 2023 17:59
@memsharded memsharded added this to the 2.0.15 milestone Nov 17, 2023
@czoido czoido merged commit 7f80c3b into conan-io:release/2.0 Nov 20, 2023
@AbrilRBS AbrilRBS deleted the rr/add-stderr-capture-conanfile-run branch December 18, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have ConanFile.run() be able to get stderr just like it does for stdout
3 participants