Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for build-missing of transitive tool-requires #15082

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Nov 10, 2023

Changelog: Bugfix: --build=missing was doing unnecessary builds of packages that were not needed and could be skipped, in the case of tool_requires having transitive dependencies.
Docs: Omit

@memsharded memsharded added this to the 2.0.15 milestone Nov 10, 2023
@memsharded memsharded marked this pull request as ready for review November 11, 2023 19:17
@memsharded memsharded modified the milestones: 2.0.15, 2.0.14 Nov 11, 2023
@memsharded memsharded requested a review from AbrilRBS November 11, 2023 19:17
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯
After playing around with this seems like pure bad luck that we didn't catch it earlier

@memsharded
Copy link
Member Author

After playing around with this seems like pure bad luck that we didn't catch it earlier

The main reason could be that it doesn't really fail, but it builds from source, so unless it is something slow and you are paying attention, it can go unnoticed. And of course, also that the scenario is not that common:

  • tool_requires with transitive dependencies
  • Doing a --build=missing
  • Actually missing those transitive dependencies binaries, which is very unlikely (I realized because I copied to a private repo and remove conancenter remote)

@czoido czoido merged commit 0d55d67 into conan-io:release/2.0 Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants