Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RISC-V #15053

Merged
merged 1 commit into from
Nov 3, 2023
Merged

RISC-V #15053

merged 1 commit into from
Nov 3, 2023

Conversation

SSE4
Copy link
Contributor

@SSE4 SSE4 commented Nov 3, 2023

add some basic RISC-V support to the default conan settings.

I've tested a few popular recipes of different build systems, e.g.:

  • custom (OpenSSL)
  • CMake (JsonCpp, GTest)
  • AutoTools (libxml2, libiconv)
  • Meson (pixman)

and all were built successfully with no issues.

Changelog: Feature: Added riscv64, riscv32 architectures to default settings.yml and management of them in Meson and Autotools.
Docs: omit

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

Isn't it missing some declarations in settings.yml?

arch: [x86, x86_64, ppc32be, ppc32, ppc64le, ppc64,
       armv4, armv4i, armv5el, armv5hf, armv6, armv7, armv7hf, armv7s, armv7k, armv8, armv8_32, armv8.3, arm64ec,
       sparc, sparcv9,
       mips, mips64, avr, s390, s390x, asm.js, wasm, sh4le,
       e2k-v2, e2k-v3, e2k-v4, e2k-v5, e2k-v6, e2k-v7,
       xtensalx6, xtensalx106, xtensalx7]

Without this, this would probably fail

@memsharded memsharded self-assigned this Nov 3, 2023
@SSE4
Copy link
Contributor Author

SSE4 commented Nov 3, 2023

Isn't it missing some declarations in settings.yml?

I think that line: https://github.com/conan-io/conan/pull/15053/files#diff-d9e6bd075cc423e1741e5ccd98478ecad42edc871876d02f63e2965c3ef07cbeR80

@memsharded
Copy link
Member

@memsharded memsharded added this to the 2.0.14 milestone Nov 3, 2023
@memsharded memsharded merged commit 87fc478 into conan-io:release/2.0 Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants