-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package_manager: handle linux mint #15026
package_manager: handle linux mint #15026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @RMZeroFour
Could you please add this to the tests? In def test_package_manager_distro(distro, tool):
test, it should be just a new entry.
There should probably be a helpful error or at least a warning on systems where the default package manager cannot be found and the user hasn't set one, right now Conan only prints out the name of the package not found, with no indication for why (no package manager). I'd be willing to contribute another commit for raising said error, if someone would be kind enough to point me to where might be the best place for this. Will the run() method below be a suitable place to raise an error, if self._active_tool is not set? |
Sounds that the |
Gotcha, that makes sense. A self._conanfile.output.info at the end of the get_default_tool function should work right? Please have a look. |
Sounds good, approved, it will be merged for next 2.0.14 release, thanks again! |
Changelog: Fix: Default to apt-get package manager in Linux Mint
Docs: conan-io/docs#3441
develop
branch, documenting this one.Linux Mint, being based on Ubuntu, should default to using the apt-get package manager. Being a decently popular OS for Linux beginners, ideally Conan should work on it with as little configuration from the user as possible, and the tool name is one such configuration that can be preset.
Right now it fails to install system packages even with sudo=True and mode=install in the global.conf file, as it doesn't know which package manager to use.