Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conan cache backup-upload #15013

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Oct 25, 2023

Changelog: Feature: Add conan cache backup-upload to upload all the backup sources in the cache, regardless of which references they are from
Docs: conan-io/docs#3438

Took me a bit to find the better way to cleanly separate the backup file recolection api, but I like how simple it looks in the end.

Not sold on the api names nor command names, but those are minor details that can be changed before merging, the PR is more to see if we like this approach

Note that I tried to add an option akin to the --metdata flag in conan upload, but quickly found that it didn't feel a nice fit, so turned away from it

@AbrilRBS AbrilRBS requested a review from memsharded October 25, 2023 19:08
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! it is indeed clean and nice.

Just a minor comment about the public API, if we wanted to avoid splitting it into 2, but not really opposed to current proposal.

conan/api/subapi/upload.py Outdated Show resolved Hide resolved
conans/client/downloaders/download_cache.py Outdated Show resolved Hide resolved
@AbrilRBS AbrilRBS linked an issue Oct 26, 2023 that may be closed by this pull request
1 task
@AbrilRBS AbrilRBS marked this pull request as ready for review October 26, 2023 05:56
@AbrilRBS AbrilRBS changed the title Add conan cache backup-upload Add conan cache backup-upload Oct 26, 2023
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@czoido czoido added this to the 2.0.14 milestone Oct 26, 2023
@czoido czoido merged commit 255171f into conan-io:release/2.0 Oct 26, 2023
@AbrilRBS AbrilRBS deleted the rr/backup-upload-unknown branch October 26, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[question] backup third-party source not done if the package already exists
3 participants