Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upload] Ignore metadata when passing empty string #15007

Merged

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Oct 24, 2023

  • Added the support to ignore metadata upload when passing --metadata="" to conan upload command.
  • Mixing no upload for metadata with a pattern for upload is considered invalid and user error (e.g `--metadata="" --metadata="logs/*")
  • Add 2 new tests to validate metadata ignored upload
  • Replaced duplicated pattern for package create and metadata create by regular methods in metadata upload test file.

Changelog: Feature: Ignore metadata upload by passing --metadata=""
Docs: conan-io/docs#3436

closes #15006

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries marked this pull request as ready for review October 24, 2023 15:00
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@memsharded memsharded added this to the 2.0.14 milestone Oct 25, 2023
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@memsharded memsharded merged commit c84550c into conan-io:release/2.0 Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Avoid uploading metadata when not required
2 participants