editable shouldn't download sources #15004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we should omit docs on this one, maybe a note to clarify this behavaiour would be nice? It might be suprising behaviour for people that run this if they expected all sources to be fetched. |
AbrilRBS
approved these changes
Oct 25, 2023
franramirez688
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix:
tools.build:download_source=Truewill not fail when there are editable packages.Docs: conan-io/docs#3448
Close #15003
Note I have opted for not trying to do the download. The download can be a destructive action, removing local changes, which defeats the purpose of editables.
conan sourcemust be manually called by users on the editable explicitly, but it will not be called by the consumersinstalleven iftools.build:download_source=True.