Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve output upload #14984

Merged
merged 7 commits into from
Oct 23, 2023
Merged

improve output upload #14984

merged 7 commits into from
Oct 23, 2023

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Oct 20, 2023 •
edited
Loading

Changelog: Feature: Better output messages in conan upload
Docs: Omit

Close #14953

@memsharded memsharded added this to the 2.0.14 milestone Oct 20, 2023
@memsharded memsharded mentioned this pull request Oct 20, 2023
Closed
1 task
memsharded and others added 2 commits October 20, 2023 12:57
@memsharded @AbrilRBS
Update conans/client/cmd/uploader.py
480db5c 
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
@memsharded
fix test
1861488
@BobIsOnFire
Copy link
Contributor

I've just checked on my build, looks awesome, thanks! Just two more nitpicks:

  • Section with source backups would enjoy its own subtitle. It also gets executed after the "Upload complete", so I guess upload is not yet complete at that point :)
  • I think "Upload summary:" message also needs to be highlighted somehow

image

@memsharded
Copy link
Member Author

Good ideas, added them, please check.

@AbrilRBS
Copy link
Member

AbrilRBS commented Oct 20, 2023 •
edited
Loading

Wow this looks so good now. Let's wait for @BobIsOnFire's comments for a few days before merging, but looks good to me!

BobIsOnFire
BobIsOnFire approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@BobIsOnFire BobIsOnFire left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you, much better!

image

@memsharded memsharded merged commit 261fe93 into conan-io:release/2.0 Oct 23, 2023
@memsharded memsharded deleted the feature/improve_output_upload branch October 23, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobIsOnFire BobIsOnFire BobIsOnFire approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
2.0.14
Development

Successfully merging this pull request may close these issues.

More detailed messages from conan upload
3 participants
@memsharded @BobIsOnFire @AbrilRBS