Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix conan source with python_requires in remotes #14852

Merged
merged 2 commits into from
Oct 2, 2023
Merged

fix conan source with python_requires in remotes #14852

merged 2 commits into from
Oct 2, 2023

Conversation

memsharded
Copy link
Member

Changelog: Fix: Define remotes in conan source command in case recipe has python_requires that need to be downloaded from remotes.
Docs: Omit

Close #14848

@memsharded memsharded added this to the 2.0.14 milestone Sep 29, 2023
@memsharded memsharded mentioned this pull request Sep 29, 2023
Closed
AbrilRBS
AbrilRBS approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Between this and what we found a few weeks ago, wondering if we should check the api's usage in the code, in case we can cath some extra issues

@czoido czoido merged commit cab151c into conan-io:release/2.0 Oct 2, 2023
@memsharded memsharded deleted the fix/source_python_requires_remotes branch October 2, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@docbrown1955 docbrown1955 docbrown1955 left review comments

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@czoido czoido czoido approved these changes

Assignees

@czoido czoido

Labels
None yet
Projects
None yet
Milestone
2.0.14
Development

Successfully merging this pull request may close these issues.

[bug] conan source failing with python_requires
4 participants
@memsharded @czoido @AbrilRBS @docbrown1955