Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly lock release candidates of python requires #14846

Merged

Conversation

AbrilRBS
Copy link
Member

Changelog: Bugfix: Properly lock release candidates of python requires
Docs: Omit

The core.version_ranges:resolve_prereleases conf works fine for resolving python require prereleases, but a missing argument was not letting lockfiles to also work, this fixes it

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good catch!
Indeed resolve_prereleases=None was there as default, but no one passing ever a value into it 🤦‍♂️

@memsharded memsharded added this to the 2.0.14 milestone Sep 29, 2023
Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@memsharded memsharded merged commit e8eb316 into conan-io:release/2.0 Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants