Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/version range pres #14814

Merged
merged 9 commits into from
Oct 17, 2023
Merged

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Sep 24, 2023

Changelog: BugFix: Version ranges ending with - do not automatically activate pre-releases resolution in the full range.
Changelog: BugFix: Fix version ranges so pre-releases are correctly included in the lower bound and excluded in the upper bound.
Docs: conan-io/docs#3454

Close #14803

@memsharded memsharded added this to the 2.0.12 milestone Sep 24, 2023
@AbrilRBS AbrilRBS self-requested a review September 25, 2023 18:42
@czoido czoido modified the milestones: 2.0.12, 2.0.13 Sep 26, 2023
@AbrilRBS AbrilRBS marked this pull request as draft September 26, 2023 11:28
@czoido czoido modified the milestones: 2.0.13, 2.0.14 Sep 28, 2023
@memsharded memsharded marked this pull request as ready for review October 16, 2023 09:26
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to make it clear in the docs that the range to allow for 2.0-prereleases is now [... <=2] where before it was only [... <2] when activating pres

Just for confirmation: [>1 <=2.0-] does not actually accept the 2.0-pres anymore

@czoido czoido merged commit 20ed811 into conan-io:release/2.0 Oct 17, 2023
@memsharded memsharded deleted the fix/version_range_pres branch October 17, 2023 08:11
@aander80
Copy link

Very happy to see these changes, thanks! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to include pre-releases in the lower bound of a version range
4 participants