Change the default check=False in conan.tools.system.package_manager.Apt to True #14728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 14, 2023
Closed
NoWiseMan
pushed a commit
to NoWiseMan/conan
that referenced
this pull request
Sep 19, 2023
…Apt to True (conan-io#14728) * check if we can change default * fix arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Change the default
check=Falseinconan.tools.system.package_manager.ApttoTrueas the other package manager tools.Docs: conan-io/docs#3380
Closes: #14708
This PR is just to discuss the idea of changing the default in Apt for check, after the issue in #14708
I can't find any historical reasons for that change in the default, so it can probably be considered a bug. Apparently, the risk of breaking users who relied on the bug wouldn't be significant, as all existing uses of these tools in the Conan Center Index set the 'check' argument to 'True' explicitly.