Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skipped binaries that depends on non-skipped binaries #14673

Merged

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Sep 5, 2023

Changelog: Bugfix: Do not binary-skip packages that have transitive dependencies that are not skipped, otherwise the build chain of build systems to those transitive dependencies like CMakeDeps generated files are broken.
Docs: Omit

Close #14541

@memsharded memsharded added this to the 2.0.11 milestone Sep 5, 2023
@memsharded memsharded self-assigned this Sep 5, 2023
@memsharded memsharded marked this pull request as draft September 6, 2023 08:42
@memsharded memsharded requested a review from jcar87 September 6, 2023 23:18
@memsharded memsharded marked this pull request as ready for review September 6, 2023 23:19
Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, let's add a good changelog explanation and reformulate the title of this PR, as it's adding a bugfix to the graph.

@memsharded memsharded changed the title new test for header-only propagation Fix skipped binaries that depends on non-skipped binaries Sep 14, 2023
@memsharded memsharded merged commit 9e569dd into conan-io:release/2.0 Sep 14, 2023
@memsharded memsharded deleted the test/transitive_header_only_static branch September 14, 2023 12:05
NoWiseMan pushed a commit to NoWiseMan/conan that referenced this pull request Sep 19, 2023
…4673)

* new test for header-only propagation

* fixing missing intermediate packages

* fix tests

* fixes tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[question] Why is full_deploy skipping binaries
4 participants