allow regex pattern for conf tools.info.package_id:confs #14621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorsten-klein
changed the title
thorsten-klein
changed the title
memsharded
reviewed
Aug 31, 2023
There was a problem hiding this comment.
Thanks for your contribution!
I think this is looking good, but I'd try to generalize it to cover also user.* confs, I think it is doable.
Also, it is better if you target the release/2.0 branch, as that means it will go into the next 2.0.11, not need to wait until the 2.1.
conans/model/conf.py
Outdated
| # Pruning any empty values, those should not affect package ID | ||
| if value: | ||
| result.define(conf_name, value) | ||
| matching_confs = [c for c in BUILT_IN_CONFS if re.match(conf_name, c)] or [conf_name] |
There was a problem hiding this comment.
A quick question: If we also want to match the user.mycomp.* confs, then we would need to iterate better the defined values in the current conf, rather than matching against the BUILT_IN_CONFS? I think this would be a more general approach.
thorsten-klein
force-pushed
the
issue-14620-conf-pattern
branch
from
608b6dc to
c6e276b
Compare
memsharded
approved these changes
Sep 1, 2023
AbrilRBS
approved these changes
Sep 1, 2023
czoido
approved these changes
Sep 1, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Supporting regex pattern for conf
tools.info.package_id:confsDocs: conan-io/docs#3382
Ref: #14620
developbranch, documenting this one.