Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tools.files.download:verify #14508

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Aug 17, 2023

Changelog: Feature: Add tools.files.download:verify.
Docs: conan-io/docs#3341
As a look into to see if we event want this.

The motivation from this comes from trying to locally develop packages whose sources do not play nice with our JFrog VPN. This is usually pkgconf (For me and @jcar87 both at least), but I've seen it in a few others.

As editing the recipe is a pain in the neck, my usual go-to is changing Conan not to verify any download, which is not ideal either.

This would allow to do things such as
conan create . --version=1.0.0 --build=missing -c:b "pkgconf/*:tools.files.download:verify=False" and have finegrained control over the verification.

Another possible solution if this does not go thru is to use the backup of CCI sources. I'm not 100% sure that an exception on origin will trigger a check of the backups, it might be worth considering if not.

Also, tests are missing because I'm not quite sure how to properly test this. Mocking the downloader seems like the way to go, but I still need to check on that

@AbrilRBS AbrilRBS requested a review from memsharded August 17, 2023 12:34
@AbrilRBS AbrilRBS self-assigned this Aug 17, 2023
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the use case and this might be useful for other users, most likely not best practice (document it explicitly this shouldn't be done in production), but still useful under some dev circumstances, I don't oppose to adding it.

@AbrilRBS AbrilRBS marked this pull request as ready for review August 21, 2023 12:20
@memsharded memsharded added this to the 2.0.10 milestone Aug 22, 2023
@memsharded memsharded merged commit 5697c07 into conan-io:release/2.0 Aug 22, 2023
@AbrilRBS AbrilRBS deleted the rr/verify-download-conf branch August 29, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants