Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Add
tools.files.download:verify
.Docs: conan-io/docs#3341
As a look into to see if we event want this.
The motivation from this comes from trying to locally develop packages whose sources do not play nice with our JFrog VPN. This is usually
pkgconf
(For me and @jcar87 both at least), but I've seen it in a few others.As editing the recipe is a pain in the neck, my usual go-to is changing Conan not to verify any download, which is not ideal either.
This would allow to do things such as
conan create . --version=1.0.0 --build=missing -c:b "pkgconf/*:tools.files.download:verify=False"
and have finegrained control over the verification.Another possible solution if this does not go thru is to use the backup of CCI sources. I'm not 100% sure that an exception on origin will trigger a check of the backups, it might be worth considering if not.
Also, tests are missing because I'm not quite sure how to properly test this. Mocking the downloader seems like the way to go, but I still need to check on that