new tools.deployer:symlinks conf for deployers #14461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
commented
Aug 10, 2023
| symlinks = conanfile.conf.get("tools.deployer:symlinks", check_type=bool, default=True) | ||
| try: | ||
| shutil.copytree(dep.package_folder, new_folder, symlinks=symlinks) | ||
| except Exception as e: |
There was a problem hiding this comment.
This is quite difficult to test, to make it fail we could be mocking shutil.copytree because it is not possible for a test to force the symlinks error as that requires multi-platform
AbrilRBS
approved these changes
Aug 10, 2023
franramirez688
approved these changes
Aug 11, 2023
|
If the test was not there, the code didn't change enough to think of it now. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: New
tools.deployer:symlinksconfiguration to disable symlinks copy in deployers.Changelog: Fix: Better error message when a built-in deployer failed to copy files.
Docs: conan-io/docs#3335
Close #14456
Close #14451