Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify --channel is not passed without --user #14443

Merged

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Aug 8, 2023

Changelog: Bugfix: Better error when passing --channel without --user.
Docs: Omit

Addresses half of #14430

@AbrilRBS AbrilRBS requested a review from memsharded August 8, 2023 10:52
@AbrilRBS AbrilRBS added this to the 2.0.10 milestone Aug 8, 2023
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Lets handle the other user request (directing stacktraces to stderr) in a different PR

@AbrilRBS AbrilRBS linked an issue Aug 8, 2023 that may be closed by this pull request
@AbrilRBS AbrilRBS merged commit a8184cf into conan-io:release/2.0 Aug 8, 2023
@AbrilRBS AbrilRBS deleted the rr/bugfix-user-no-channel-stacktrace branch August 8, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants