Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trying settings_target fix #14441

Merged
merged 8 commits into from
Aug 23, 2023
Merged

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Aug 7, 2023

Changelog: Bugfix: Fix settings_target computation for tool_requires of packages already in the "build" context.
Docs: Omit

This is a bugfix, the behavior is the expected one, so no need for docs.
Except there is no almost no docs for settings_target, this deserves its own docs, besides this PR.

Close #14421
Close #14521

@memsharded memsharded added this to the 2.0.10 milestone Aug 7, 2023
@memsharded memsharded marked this pull request as draft August 21, 2023 09:53
@memsharded memsharded marked this pull request as ready for review August 21, 2023 16:41
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a while to be able to properly udnerstand the context, but this looks good now :)

@czoido czoido merged commit 528d296 into conan-io:release/2.0 Aug 23, 2023
@memsharded memsharded deleted the fix/settings_target branch August 23, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants