Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using conanfile.run() so environment is injected #14326

Merged
merged 6 commits into from
Jul 26, 2023
Merged

using conanfile.run() so environment is injected #14326

merged 6 commits into from
Jul 26, 2023

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Jul 18, 2023 •
edited by czoido
Loading

Changelog: Fix: Invoke XCRun using conanfile.run() so that environment is injected.
Docs: Omit

Close #14297

@memsharded memsharded added this to the 2.0.9 milestone Jul 18, 2023
@memsharded memsharded marked this pull request as ready for review July 19, 2023 08:28
memsharded
memsharded commented Jul 19, 2023
View reviewed changes
Copy link
Member Author

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change means that more logs of RUN: git .... and RUN: xcrun ... will be displayed in the user output, and maybe it is too much.

Moving it to 2.0.10 and marking it as look-into

@memsharded memsharded modified the milestones: 2.0.9, 2.0.10 Jul 19, 2023
@memsharded memsharded marked this pull request as draft July 19, 2023 12:01
@memsharded memsharded mentioned this pull request Jul 24, 2023
Closed
1 task
@memsharded memsharded marked this pull request as ready for review July 24, 2023 14:56
@czoido czoido merged commit 0f2d91e into conan-io:release/2.0 Jul 26, 2023
@memsharded memsharded deleted the fix/conanfile_run branch July 26, 2023 14:42
mkmkme pushed a commit to mkmkme/conan that referenced this pull request Jul 26, 2023
@memsharded @mkmkme
using conanfile.run() so environment is injected (conan-io#14326)
2efaf71 
* using conanfile.run() so environment is injected

* fix tests

* fixes

* quiet output as before

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czoido czoido czoido approved these changes

@franramirez688 franramirez688 franramirez688 approved these changes

Assignees

@czoido czoido

Labels
None yet
Projects
None yet
Milestone
2.0.10
Development

Successfully merging this pull request may close these issues.

[question] Should XCRun use the conanfile's build env?
3 participants
@memsharded @franramirez688 @czoido