Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KeyError in backup sources when no package is selected in the pattern/options #14185

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Jun 28, 2023

Changelog: Bugfix: Fix KeyError in backup sources when no package is selected.
Docs: Omit

Thanks to @danimtb for the help :)

Adding a new test might be a bit oevrkill but that's what we used to ensure no other issues were slipping by

Closes #14184

@AbrilRBS AbrilRBS requested a review from memsharded June 28, 2023 11:45
@AbrilRBS AbrilRBS added this to the 2.0.8 milestone Jun 28, 2023
conans/client/downloaders/download_cache.py Outdated Show resolved Hide resolved
AbrilRBS and others added 2 commits June 28, 2023 14:20
@danimtb danimtb merged commit 470c8ee into conan-io:release/2.0 Jun 29, 2023
@AbrilRBS AbrilRBS deleted the rr/fix-keyerror-backupsources branch June 29, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Can't call conan upload --recipe-only twice with backup sources enabled
3 participants