Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/XcodeDeps enable custom configurations (#14149) #14168

Merged
merged 4 commits into from
Jun 26, 2023
Merged

Fix/XcodeDeps enable custom configurations (#14149) #14168

merged 4 commits into from
Jun 26, 2023

Conversation

wAuner
Copy link
Contributor

@wAuner wAuner commented Jun 26, 2023 •
edited by memsharded
Loading

Changelog: Fix: Use configuration in XcodeDeps instead of always build_type.
Docs: Omit

fixes #14149

  • adds support for Xcode custom configurations as it is already documented but not actually implemented
  • adds unit test
  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@wAuner wAuner changed the title Fix/XcodeDeps enable custom configurations #14149 Fix/XcodeDeps enable custom configurations (#14149) Jun 26, 2023
memsharded
memsharded reviewed Jun 26, 2023
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
Can you please have a look to the comment?

conans/test/integration/toolchains/apple/test_xcodedeps.py Outdated Show resolved Hide resolved
@memsharded memsharded added this to the 2.0.8 milestone Jun 26, 2023
@czoido czoido merged commit 0330a5c into conan-io:develop2 Jun 26, 2023
@memsharded memsharded mentioned this pull request Jun 26, 2023
Closed
1 task
@memsharded
Copy link
Member

This was merged to develop2, I will merge it to release/2.0 so it is in next 2.0.8 too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded left review comments

@czoido czoido czoido approved these changes

Assignees

@czoido czoido

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
2.0.8
Development

Successfully merging this pull request may close these issues.
3 participants
@wAuner @memsharded @czoido