Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use realpath() to determine cache location (#14136) #14164

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

iskunk
Copy link
Contributor

@iskunk iskunk commented Jun 23, 2023

Changelog: Fix: Respect symlinked path for cache location.
Docs: Omit

Close #14136

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@memsharded memsharded added this to the 2.0.8 milestone Jun 23, 2023
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds good, I think this can be moved forward.

It would need a "integration" test that covers this case, to make sure this is working and won't be a problem. This test needs to define the symlink scenario that the issue described, and create and use a dummy package from there, generate some file like --format=json and check the paths.

Do you think that you will be able to contribute such test? Please let us know, we can help or we can even contribute the test ourselves. Thanks for your contribution!

@iskunk
Copy link
Contributor Author

iskunk commented Jun 26, 2023

Thanks @memsharded. I doubt I'd be able to write an acceptable test for this from scratch within a reasonable timeframe, but might there be an existing test that is already pretty close to what is needed? Others I could crib relevant bits from? I should be able to mix and match.

@memsharded
Copy link
Member

Don't worry about it, I have added a test in c0104a2, that should be enough

@iskunk
Copy link
Contributor Author

iskunk commented Jun 27, 2023

Much obliged, good sir! It would have taken me quite a while to write a test that succinct :-]

@memsharded memsharded merged commit b43eb83 into conan-io:release/2.0 Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Conan mishandles cache path in symlinked homedir
2 participants