fix editable with matching paths folders #14095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franramirez688
approved these changes
Jun 15, 2023
AbrilRBS
approved these changes
Jun 15, 2023
AbrilRBS
reviewed
Jun 15, 2023
| hello_say_folder = os.path.join(client.current_folder, "hello-say").replace("\\", "/") | ||
| assert f'set(say_PACKAGE_FOLDER_RELEASE "{hello_say_folder}")' in data | ||
| env = client.load("hello/conanbuildenv-release.sh") | ||
| assert "$script_folder/deactivate_conanbuildenv-release.sh" in env.replace("\\", "/") |
There was a problem hiding this comment.
With my planned PR for these scripts to disappear, this tests would fail. Is there another file you can check for?
There was a problem hiding this comment.
Not really, better check it as my change was breaking this.
It is fine, when you introduce your change, a few tests will have to be fixed anyway, this will be just one more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Avoid incorrect path replacements for
editablepackages when folders have overlapping matching names.Docs: Omit
Close #14091