conan remove pkg-lists support
#14082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
approved these changes
Jun 13, 2023
| if args.list: | ||
| listfile = make_abs_path(args.list) | ||
| multi_package_list = MultiPackagesList.load(listfile) | ||
| package_list = multi_package_list["Local Cache" if not remote else remote.name] |
There was a problem hiding this comment.
Maybe time to move "Local Cache" to some kind of constant? (Not on this PR) It's in the codebase a few times by now
Yes, definitely. I will add tests. I was trying to make sure things didn't break and interface looked good, and I forgot to finally add them. |
AbrilRBS
approved these changes
Jun 14, 2023
memsharded
commented
Jun 14, 2023
czoido
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Allow
conan remove --list=pkglistto remove package-lists.Changelog: Feature: Output for
conan remove --formatboth text (summary of deleted things) and json.Docs: conan-io/docs#3270
Need it as pre-condition for LRU functionality in #14054