fix with caching of aggregated components #14060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
approved these changes
Jun 9, 2023
AbrilRBS
reviewed
Jun 10, 2023
| @@ -490,22 +489,24 @@ def get_sorted_components(self): | |||
|
|
|||
| def aggregated_components(self): | |||
| """Aggregates all the components as global values, returning a new CppInfo""" | |||
| if self._aggregated is None: | |||
There was a problem hiding this comment.
Asking myself if there are more instances of caching in the code that can also be an issue
There was a problem hiding this comment.
I had a quick look, there is caching in some other places related to the computation of the graph, but nothing evident at first sight that would affect the generators
czoido
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Avoid caching issues when some intermediate package in the graph calls
aggregated_components()over some dependency and using--deployer, generators still pointed to the Conan cache and not deployed copy.Docs: Omit
Close #14022