Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/premakedeps - Double absolute paths #13926

Merged
merged 1 commit into from
May 24, 2023

Conversation

Ohjurot
Copy link
Contributor

@Ohjurot Ohjurot commented May 20, 2023

OK... as it seems the only thing that I have keeps as is from the old premake5 generator is now falling on my feet...

Changelog: Bugfix: Fix "double" absolute paths in premakedeps.
Docs: Omit

Conan 2.0.5 seems to already factor in the package path when calling aggregated_components()
The premake5 implementation manually did this. This resulted in a "double" absolute path.

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

- Conan 2.0.5 seems to already factor in the package path when calling aggregated_components()
- The premake5 implementation manually did this.
- This is fixed with that commit
@CLAassistant
Copy link

CLAassistant commented May 20, 2023

CLA assistant check
All committers have signed the CLA.

@memsharded
Copy link
Member

Thanks for your contribution.

It is clear that there are not enough tests covering this, ideally this should have been captured by tests. And unfortunately it seems there is not enough demand for Premake to push this higher into our tons of things to prioritize. So thanks for keep pushing it.

@memsharded memsharded merged commit 9b67c8c into conan-io:release/2.0 May 24, 2023
@memsharded memsharded added this to the 2.0.6 milestone May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants