Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use neww uuids for new builds folders in cache #13833

Merged

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented May 6, 2023

Changelog: Feature: Allow step-into dependencies debugging for packages built locally with --build
Changelog: Feature: Allow non relocatable, locally built packages with upload_policy="skip" and build_policy="missing"
Docs: conan-io/docs#3210

Close #13799
Close #13237

This PRs does the following:

  • For the package binaries built in the cache, use a random UUID to compute their folder. Such folder will be different each time it is built, but it is also expected that the final package-revision would be different so it shouldn't be a big deal
  • The same can not be done for recipes, because creating a new folder with a random uuid each time a recipe is exported would completely invalidate the source folder, making the caching of the sources in the cache completely useless (we could use a mechanism similar to the build_id lookup in the cache, but seems overkill)
  • The downloaded packages still get downloaded to the same folder, not using uuid, but hashing the full reference including the package-revision, so they are always located in the same place (could help with compilation caches as ccache)
  • It was necessary to augment a but the conan cache clean, because builds that not succeed will leave extra trailing folders that can't be removed with conan remove as they don't have a final reference

@memsharded memsharded added this to the 2.0.5 milestone May 7, 2023
@memsharded memsharded marked this pull request as ready for review May 9, 2023 22:42
@memsharded memsharded merged commit f662596 into conan-io:release/2.0 May 12, 2023
@memsharded memsharded deleted the experiment/cache_builds_uuid branch May 12, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants