avoid hitting servers for binaries when upload_policy=skip #13771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
memsharded
commented
May 3, 2023
| if dep_node.binary == BINARY_BUILD: | ||
| with_deps_to_build = True | ||
| break | ||
| with_deps_to_build = any(dep.dst.binary == BINARY_BUILD for dep in node.dependencies) |
There was a problem hiding this comment.
this is a pure refactor, no functional change
czoido
approved these changes
May 4, 2023
franramirez688
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Optimize and avoid hitting servers for binaries when
upload_policy=skipDocs: Omit
Close #13770