Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying a custom output for the deployers #13757

Merged

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Apr 24, 2023

Changelog: Feature: Allow to specify a custom deployer output folder.
Docs: conan-io/docs#3275

Closes #13728

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I'd say we can include this in 2.0.5

conan/cli/commands/graph.py Outdated Show resolved Hide resolved
conan/cli/commands/graph.py Outdated Show resolved Hide resolved
@memsharded memsharded added this to the 2.0.5 milestone Apr 24, 2023
@memsharded
Copy link
Member

Regarding the "development re-locatable Conan-agnostic" deploys feature conan-io/examples2#94, this could be a useful use case:

  • it allows to do multiple conan install, different configurations, like linux/windows, or different compilers or architectures will require a different --output-folder or defined build_folder_vars to not overwrite each other
  • But it is not intended that every one will contain its own full_deploy copy, because for example tool_requires for the build system for a given cmake.exe, could contain multiple copies. An extra argument to redefine the full_deploy root folder could solve this.

@memsharded memsharded modified the milestones: 2.0.5, 2.0.6 May 10, 2023
@CLAassistant
Copy link

CLAassistant commented May 18, 2023

CLA assistant check
All committers have signed the CLA.

@memsharded memsharded modified the milestones: 2.0.6, 2.0.7 May 24, 2023
@AbrilRBS AbrilRBS marked this pull request as ready for review May 30, 2023 23:55
@AbrilRBS
Copy link
Member Author

Picking this back up, the PR felth thru the cracks last month

@AbrilRBS AbrilRBS self-assigned this May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[question] Conan 2.0 custom deployer + output folder
4 participants