Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/warnings quiet #13706

Merged
merged 6 commits into from
Apr 20, 2023
Merged

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Apr 17, 2023

Changelog: Feature: Introduce new core:skip_warns configuration to be able to silence some warnings in the output.
Docs: conan-io/docs#3215

Close #13517

@memsharded memsharded added this to the 2.0.5 milestone Apr 17, 2023
@memsharded memsharded requested a review from AbrilRBS April 17, 2023 07:46
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have one UX question:
I'm wondering if we're going to reuse some "id"s in the future, seeing how general the proposed deprecated one is. If so, maybe it's not warn_id but warn_category/warn_tag or the likes?

@memsharded
Copy link
Member Author

I'm wondering if we're going to reuse some "id"s in the future, seeing how general the proposed deprecated one is. If so, maybe it's not warn_id but warn_category/warn_tag or the likes?

I initially implemented some kind of abstract ID, like W01, but then I realized that it was only adding an unnecessary abstraction, and too much boilerplate in code, translating codes back an forth. So I'd prefer to have something with a bit of semantics. We can discuss if we want Wdeprecation, Wdeprecated2.0, c3i_removed, or any other, but I'd suggest using plain text identifiers with a bit of meaning.

@memsharded memsharded marked this pull request as ready for review April 18, 2023 21:00
@czoido czoido merged commit 9d18bae into conan-io:release/2.0 Apr 20, 2023
@memsharded memsharded deleted the feature/warnings_quiet branch April 20, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Provide ability to suppress Conan 1.x legacy warnings
3 participants