Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double delete error in conan cache clean #13601

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Fix double delete error in conan cache clean #13601

merged 1 commit into from
Apr 3, 2023

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Apr 3, 2023 •
edited by czoido
Loading

Changelog: Bugfix: Fix double delete error in conan cache clean.
Docs: Omit

shutils.rmtree raises when the folder does not exist. Calling conan cache clean more than once (For different references, for example), crashed. Use rmdir instead to avoid this behaviour

@AbrilRBS AbrilRBS requested a review from memsharded April 3, 2023 16:09
@memsharded memsharded added this to the 2.0.4 milestone Apr 3, 2023
@memsharded memsharded merged commit 88df96f into conan-io:release/2.0 Apr 3, 2023
@AbrilRBS AbrilRBS deleted the rr/fix-conan-cache-clean-doubledel branch April 5, 2023 09:01
This was referenced Apr 5, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
2.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@AbrilRBS @memsharded