relocatable full_deploy CMake #13526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
commented
Mar 27, 2023
| for varname, varvalues in self._values.items(): | ||
| value = varvalues.get_str("%{name}%", subsystem=self._subsystem, pathsep=self._pathsep) | ||
| # To make the script relocatable | ||
| value = value.replace(location, "%~dp0") |
There was a problem hiding this comment.
This was easy to make Env generators to be relocatable for Windows/.bat, but it is challenging to do for .sh in Linux, due to not existing a generic pure shell (no bash only) solution
| else: | ||
| updates[prop_name] = os.path.join(folder, value) | ||
| component._generator_properties.update(updates) | ||
| properties = component._generator_properties |
There was a problem hiding this comment.
This was a minor refactor, no need to iterate all properties, if only 1 used ( I had to do the same below)
| @@ -15,8 +17,30 @@ | |||
| def test_install_deploy(): | |||
| c = TestClient() | |||
| c.run("new cmake_lib -d name=hello -d version=0.1") | |||
| c.run("create . -o *:shared=True -tf=") | |||
| conanfile = textwrap.dedent(""" | |||
There was a problem hiding this comment.
Adding an actual executable script to the test, to proof the final deploy is relocatable
czoido
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: The
full_deploydeployer together withCMakeDepsgenerator learned to create relative paths deploys, so they are relocatable.Docs: Omit
Close #13511