fix meson cpp_std for VS2019 and 2022 c++20. #13450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
memsharded
reviewed
Mar 15, 2023
conan/tools/build/flags.py
Outdated
| return {"14": v14, "17": v17, "20": v20, "23": v23}.get(str(cppstd), None) | ||
|
|
||
| def _cppstd_msvc(visual_version, cppstd): | ||
| flag = cppstd_msvc_flag(visual_version, cppstd).get(str(cppstd), None) |
There was a problem hiding this comment.
It seems this is redundant?
Suggested change
| flag = cppstd_msvc_flag(visual_version, cppstd).get(str(cppstd), None) | |
| flag = cppstd_msvc_flag(visual_version, cppstd) |
lukester1975
force-pushed
the
feature/fix-meson-cppstd20
branch
2 times, most recently
from
fe43a15 to
3bbf28c
Compare
Note meson 1.0.1 is required for it to accept c++20 with clang-cl.
lukester1975
force-pushed
the
feature/fix-meson-cppstd20
branch
from
3bbf28c to
e1df479
Compare
|
Sorry yeah that first attempt was nonsense... Hopefully good now. |
memsharded
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Generate
cpp_std=vc++20for c++20 with meson with VS2019 and VS2022, rather thanvc++latest.Docs: Omit
Fixes #13424
Note meson 1.0.1 is required for it (meson) to accept
vc++20with clang-cl.Given the comment about
_msvc_supported_cppstdin the issue, I've made a slight change from the version there. It looks like_msvc_supported_cppstdreports VS2019 as only supporting up to c++20, so I've kept c++23 as VS2022 only in this version.Thanks