Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global verbosity conf tools.build:verbosity #13428

Merged
merged 26 commits into from
Mar 15, 2023
Merged

Add global verbosity conf tools.build:verbosity #13428

merged 26 commits into from
Mar 15, 2023

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Mar 13, 2023 •
edited by czoido
Loading

Changelog: Bugfix: Add global verbosity conf tools.build:verbosity instead of individual ones.
Docs: conan-io/docs#3107

Adds tools.build:verbosity which tries to unify the verbosity levels of the build systems.

Right now XCode and MSBuild

@AbrilRBS AbrilRBS requested a review from memsharded March 13, 2023 14:39
@AbrilRBS AbrilRBS marked this pull request as draft March 13, 2023 14:39
@memsharded
Copy link
Member

As for CMake, there's CMAKE_VERBOSE_MAKEFILE (Requested in #12239) to control the build verbosity itself, but is set to FALSE by default by the project() so I don't think adding it to the toolchain would actually work? I still need to test locally

It can be added to the presets file too via CMakeToolchain, and it will be passed in command line arg

memsharded
memsharded reviewed Mar 13, 2023
View reviewed changes
conan/tools/apple/xcodebuild.py Outdated Show resolved Hide resolved
conan/tools/apple/xcodebuild.py Outdated Show resolved Hide resolved
memsharded
memsharded reviewed Mar 13, 2023
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll try to add the CMAKE_MAKE_VERBOSE thing in it, and if there would be a way that the CMake + VS could also print verbose compile command lines, that would be great.

conan/tools/cmake/cmake.py Outdated Show resolved Hide resolved
AbrilRBS and others added 2 commits March 13, 2023 17:45
@AbrilRBS @memsharded
Update conan/tools/cmake/cmake.py
12058a5 
Co-authored-by: James <memsharded@gmail.com>
@AbrilRBS
Use proper conf name
628ed97
@AbrilRBS AbrilRBS self-assigned this Mar 13, 2023
@AbrilRBS AbrilRBS closed this Mar 13, 2023
@AbrilRBS AbrilRBS reopened this Mar 13, 2023
@AbrilRBS AbrilRBS closed this Mar 14, 2023
@AbrilRBS AbrilRBS reopened this Mar 14, 2023
@AbrilRBS AbrilRBS changed the title Add global verbosity conf tools.build.verbosity Add global verbosity conf tools.build:verbosity Mar 14, 2023
memsharded
memsharded approved these changes Mar 14, 2023
View reviewed changes
conan/tools/cmake/toolchain/toolchain.py Outdated Show resolved Hide resolved
@czoido czoido added this to the 2.0.2 milestone Mar 14, 2023
@AbrilRBS AbrilRBS modified the milestones: 2.0.2, 2.0.3 Mar 14, 2023
@AbrilRBS AbrilRBS modified the milestones: 2.0.3, 2.0.2 Mar 15, 2023
@AbrilRBS AbrilRBS marked this pull request as ready for review March 15, 2023 09:09
@memsharded memsharded assigned czoido and unassigned AbrilRBS Mar 15, 2023
@czoido czoido merged commit 8c424de into conan-io:release/2.0 Mar 15, 2023
@memsharded memsharded mentioned this pull request Apr 16, 2023
Closed
1 task
@Tails86 Tails86 mentioned this pull request Apr 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

@czoido czoido czoido approved these changes

Assignees

@czoido czoido

Labels
None yet
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@AbrilRBS @memsharded @czoido