Nicer error in the compatibility plugin with custom compilers #13328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Nicer error in the compatibility plugin with custom compilers.
Docs: Omit
After seeing #13325, figured I'd improve the UX of the raised error. My first idea was to make the function return an empty list if the compiler was not known, but that would change current behaviour and so I decided to at least improve the generated exception, happy to discuss if going that way would work or not (Mostly so I get to learn about it a bit more :))
Also, I noticed that the plugin code itself is not currently directly tested and we might want to look into improving that, but I tried and got hit a wall because of how the function is defined in the code, it makes it hard to test. We could get it to run by running the same code that the
test_migrations
code does, but I was not able to come up with a test that exercised the compatibility feature, so any help is welcomed!