Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds qcc cppstd compatibility info #13326

Merged
merged 2 commits into from
Mar 6, 2023
Merged

adds qcc cppstd compatibility info #13326

merged 2 commits into from
Mar 6, 2023

Conversation

tannerbitz
Copy link
Contributor

@tannerbitz tannerbitz commented Mar 4, 2023

Changelog: Bugfix: adds qcc cppstd compatibility info to allow dep graph to be calculated.
Docs: Omit

Close #13325

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@CLAassistant
Copy link

CLAassistant commented Mar 4, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, many thanks!
Do you think you could add some unit test to cover this so it doesn't break in the future?
If not, we can help with that.

@memsharded memsharded added this to the 2.0.2 milestone Mar 5, 2023
@memsharded
Copy link
Member

The PR is targeted to develop2 branch, if we want to have it in 2.0.2, it should be targeted to release/2.0 branch

@tannerbitz
Copy link
Contributor Author

tannerbitz commented Mar 5, 2023

The PR is targeted to develop2 branch, if we want to have it in 2.0.2, it should be targeted to release/2.0 branch

@memsharded thank you for the correction. This is my first contribution to the conan project and and didn't know that! I have reset the target branch on this PR. Does a second PR need to be opened to merge this into develop2 or will this PR suffice?

@tannerbitz tannerbitz changed the base branch from develop2 to release/2.0 March 5, 2023 22:37
@memsharded
Copy link
Member

@memsharded thank you for the correction. This is my first contribution to the conan project and and didn't know that! I have reset the target branch on this PR. Does a second PR need to be opened to merge this into develop2 or will this PR suffice?

This PR is enough, we manage all the sync between branches internally.

What about the above mentioned test? Do you think that you will be able to contribute a unit test, or would you like some help with that? Thanks!

@tannerbitz
Copy link
Contributor Author

@memsharded thank you for the correction. This is my first contribution to the conan project and and didn't know that! I have reset the target branch on this PR. Does a second PR need to be opened to merge this into develop2 or will this PR suffice?

This PR is enough, we manage all the sync between branches internally.

What about the above mentioned test? Do you think that you will be able to contribute a unit test, or would you like some help with that? Thanks!

@memsharded I can write the unit test, but admittedly haven't written one in python before. Can you point me to where I need to put it in the codebase?

@tannerbitz
Copy link
Contributor Author

tannerbitz commented Mar 6, 2023

@memsharded I think I figured out the unittest. It runs and passes (locally at least, CI will tell the true story in a couple minutes). Please let me know if more needs to be added.

@memsharded
Copy link
Member

@memsharded I think I figured out the unittest. It runs and passes (locally at least, CI will tell the true story in a couple minutes). Please let me know if more needs to be added.

That's perfect, thanks very much! Merging this, so this becomes part of next 2.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants