-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds qcc cppstd compatibility info #13326
adds qcc cppstd compatibility info #13326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, many thanks!
Do you think you could add some unit test to cover this so it doesn't break in the future?
If not, we can help with that.
The PR is targeted to develop2 branch, if we want to have it in 2.0.2, it should be targeted to |
@memsharded thank you for the correction. This is my first contribution to the conan project and and didn't know that! I have reset the target branch on this PR. Does a second PR need to be opened to merge this into develop2 or will this PR suffice? |
This PR is enough, we manage all the sync between branches internally. What about the above mentioned test? Do you think that you will be able to contribute a unit test, or would you like some help with that? Thanks! |
@memsharded I can write the unit test, but admittedly haven't written one in python before. Can you point me to where I need to put it in the codebase? |
@memsharded I think I figured out the unittest. It runs and passes (locally at least, CI will tell the true story in a couple minutes). Please let me know if more needs to be added. |
That's perfect, thanks very much! Merging this, so this becomes part of next 2.0.2 |
Changelog: Bugfix: adds qcc cppstd compatibility info to allow dep graph to be calculated.
Docs: Omit
Close #13325
develop
branch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.