Ensure topics and provides are always serialized as lists #13298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of how they were defined
memsharded
approved these changes
Mar 2, 2023
memsharded
requested changes
Mar 2, 2023
memsharded
approved these changes
Mar 2, 2023
czoido
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Ensure that
topicsare always serialized as lists.Docs: omit
Changelog: Bugfix: Ensure that
providesare always serialized as lists.Docs: omit
This came about with cci's CI breaking due to a broken logic that assumed topics were always a list, which was not the case for some of the recipes. After hotfixing its code, this PR now aims to ensure that both
topicsandprovidesare always serialized as lists, even if the recipe defines only a string for those attributes.