Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove vcvars telemetry #13293

Merged
merged 3 commits into from
Mar 2, 2023
Merged

remove vcvars telemetry #13293

merged 3 commits into from
Mar 2, 2023

Conversation

memsharded
Copy link
Member

Changelog: Fix: Remove vcvars.bat VS telemetry env-var, to avoid Conan hanging.
Docs: Omit

Lets see if this doesn't break anything.
Close #13196

@memsharded memsharded added this to the 2.0.1 milestone Mar 1, 2023
@memsharded memsharded marked this pull request as ready for review March 2, 2023 10:40
AbrilRBS
AbrilRBS approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good idea, and I don't see how disabling telemetry would break anyone (Let's hope noone is relying on the logo output tho)

conan/tools/microsoft/visual.py Show resolved Hide resolved
@AbrilRBS AbrilRBS merged commit 6d03384 into conan-io:release/2.0 Mar 2, 2023
@memsharded memsharded deleted the fix/vcvars_telemetry branch March 2, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.

[question] Possible Conan 2.0 issue w/ VCVars generator
2 participants
@memsharded @AbrilRBS