Improve error message for unified patterns in options #13264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include the option in the proposed solution to make it easier for the user to understand the new unified pattern syntax. Also, avoid advocating `pkg*:option` to prevent ambiguities with libraries with the same prefix, e.g. `pkg-ng`. Only propose using the more explicit `pkg/*:option` notation.
|
|
memsharded
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Improve error message for unified patterns in options.
Docs: omit
Include the option in the proposed solution to make it easier for the user to understand the new unified pattern syntax.
Also, avoid advocating
pkg*:optionto prevent ambiguities with libraries with the same prefix, e.g.pkg-ng. Only propose using the more explicitpkg/*:optionnotation.See #13233 (comment)